tgorordo/carousel
1
0
Fork 0
mirror of https://github.com/tgorordo/carousel.git synced 2026-06-14 21:32:14 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

switch using it.permutations in check_unstable for legibility

Browse source
This commit is contained in:
Thomas (Tom) C. Gorordo 2025-04-18 02:35:11 -07:00
parent 55aa0b8e43
commit 85f1b71d3f
Signed by: tgorordo
GPG key ID: 0CBED22BB0D94490
1 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/carousel/__init__.py
View file

@ -85,7 +85,7 @@ def get_rank(ranking, ranker, rankee):
def check_unstable(match, applicant_ranking, reviewer_ranking): def check_unstable(match, applicant_ranking, reviewer_ranking):
applicants = applicant_ranking.columns[1:] # assume unique applicants applicants = applicant_ranking.columns[1:] # assume unique applicants
for a, b in it.combinations(applicants, 2): for a, b in it.permutations(applicants, 2):
A = ( A = (
match.select(c for c in match.iter_columns() if a in c).to_series().name match.select(c for c in match.iter_columns() if a in c).to_series().name
) # the reviewer a is matched to ) # the reviewer a is matched to
@ -101,16 +101,6 @@ def check_unstable(match, applicant_ranking, reviewer_ranking):
) )
if b_prefers_A and A_prefers_b: if b_prefers_A and A_prefers_b:
return True return True
# or
a_prefers_B = get_rank(applicant_ranking, a, B) < get_rank(
applicant_ranking, a, A
)
B_prefers_a = get_rank(reviewer_ranking, B, a) < get_rank(
reviewer_ranking, B, b
)
if a_prefers_B and B_prefers_a:
return True
# else # else
return False return False