From 8e3d78114e5c27c8138d73595f568d4d40807b68 Mon Sep 17 00:00:00 2001 From: "Thomas (Tom) C. Gorordo" <57684088+tgorordo@users.noreply.github.com> Date: Tue, 3 Sep 2024 22:25:43 -0700 Subject: [PATCH] remove extraneous commented binomial implementation --- src/primefactorization.jl | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/src/primefactorization.jl b/src/primefactorization.jl index 5949104..0697f23 100644 --- a/src/primefactorization.jl +++ b/src/primefactorization.jl @@ -385,26 +385,6 @@ function sumlist!(list::Vector{<:PrimeFactorization}, ind = 1:length(list)) return MPZ.mul!(s, _convert!(i, g)) end -#= -# A cached binomial implementation. -bcache = LRU{Tuple{BigInt, BigInt}, PrimeFactorization}(; maxsize=10^6) -function primebinomial(n::BigInt, k::BigInt) - T = PrimeFactorization{eltype(eltype(factorialtable))} - if k == 0 - return one(T) - end # guard - if haskey(bcache, (n, k)) - return bcache[(n, k)] - else - den = primefactor(k) - num = mul!(copy(primefactor(n + 1 - k)), primebinomial(n, k - 1)) - res = divexact!(num, den) - bcache[(n, k)] = res - return res - end -end -=# - function primebinomial(n::BigInt, k::BigInt) num = copy(primefactorial(n)) divexact!(num, primefactorial(k))